[
https://issues.apache.org/jira/browse/BEAM-7274?focusedWorklogId=304338&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-304338
]
ASF GitHub Bot logged work on BEAM-7274:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/19 15:46
Start Date: 30/Aug/19 15:46
Worklog Time Spent: 10m
Work Description: alexvanboxel commented on pull request #8690:
[BEAM-7274] Implement the Protobuf schema provider
URL: https://github.com/apache/beam/pull/8690#discussion_r319572196
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/values/Row.java
##########
@@ -554,6 +555,12 @@ public Builder withFieldValueGetters(
return this;
}
+ /** The FieldValueGetters will handle the conversion for Arrays, Maps and
Rows. */
+ public Builder withFieldValueGettersHandleCollections(boolean
collectionHandledByGetter) {
+ this.collectionHandledByGetter = collectionHandledByGetter;
+ return this;
+ }
Review comment:
OK, maybe the name could be better, but it means that the the
FieldValueGetters also handle collections like ARRAY, ROW, MAP. If you go to
the original implementation (
https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java#L90
) you see that RowWithGetters does naive handling of ARRAY, ROW and MAP, for
protobuf you need more context (the descriptor) to handle them. That's why I
need to disable the naive mapping and let the FieldValueGetters handle ARRAY,
ROW and MAP.
Feel free to suggest a better name though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 304338)
Time Spent: 5h 50m (was: 5h 40m)
> Protobuf Beam Schema support
> ----------------------------
>
> Key: BEAM-7274
> URL: https://issues.apache.org/jira/browse/BEAM-7274
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Minor
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> Add support for the new Beam Schema to the Protobuf extension.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
