[
https://issues.apache.org/jira/browse/BEAM-7274?focusedWorklogId=304836&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-304836
]
ASF GitHub Bot logged work on BEAM-7274:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Aug/19 11:49
Start Date: 31/Aug/19 11:49
Worklog Time Spent: 10m
Work Description: alexvanboxel commented on issue #8690: [BEAM-7274]
Implement the Protobuf schema provider
URL: https://github.com/apache/beam/pull/8690#issuecomment-526824271
@reuvenlax I think I tackled all your concerns you posted. The build is
failing, but this is due to a warning in Jenkins that has nothing todo with
this PR (I investigated). The PR is also rebased.
- Reverted changes to Row so it's back to the original implementation,
except for the need of `collectionHandledByGetter` see remark above. (better
name always welcome)
- ProtoDescriptorSerializer is gone. I defined a ProtoDomain class that the
user needs to use themself if they want to use DynamicMessages. having one
ProtoDomain for all messages that belong together will make sure object
equality works.
- ProtoSchemaProvider only handles compiled Proto classes, it will give an
error on DynamicMessages.
- ProtoSchema is the workhorse, it's a bit like AvroSchemaUtils.
It would be great having this in the next release. From then on we can do
incremental changes like:
- Documentation
- Option handling
- Logical types
I also backported the ProtoDomain on the DynamicMessage PR to align it with
this.
Sorry it took so long, but I needed to prioritize something different, but
related with Proto (a proto schema registry).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 304836)
Time Spent: 6h 10m (was: 6h)
> Protobuf Beam Schema support
> ----------------------------
>
> Key: BEAM-7274
> URL: https://issues.apache.org/jira/browse/BEAM-7274
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Minor
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> Add support for the new Beam Schema to the Protobuf extension.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
