[
https://issues.apache.org/jira/browse/BEAM-5428?focusedWorklogId=304532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-304532
]
ASF GitHub Bot logged work on BEAM-5428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/19 19:18
Start Date: 30/Aug/19 19:18
Worklog Time Spent: 10m
Work Description: mxm commented on issue #9440: [BEAM-5428] Modify cache
token Proto design to only include tokens in ProcessBundleRequest
URL: https://github.com/apache/beam/pull/9440#issuecomment-526717957
Not sure what is the issue, but I get this generated code (excerpt below)
which does not compile. Everything else is setup correctly and I can run the
tests. This is not important for this PR, but I just wondered if I'm doing
anything obvious wrong.
```diff
diff --git a/sdks/go/pkg/beam/model/fnexecution_v1/beam_fn_api.pb.go
b/sdks/go/pkg/beam/model/fnexecution_v1/beam_fn_api.pb.go
index eff5c3258e..8fae66602f 100644
--- a/sdks/go/pkg/beam/model/fnexecution_v1/beam_fn_api.pb.go
+++ b/sdks/go/pkg/beam/model/fnexecution_v1/beam_fn_api.pb.go
@@ -3,17 +3,18 @@
package fnexecution_v1
-import proto "github.com/golang/protobuf/proto"
-import fmt "fmt"
-import math "math"
-import pipeline_v1
"github.com/apache/beam/sdks/go/pkg/beam/model/pipeline_v1"
-import _ "github.com/golang/protobuf/protoc-gen-go/descriptor"
-import timestamp "github.com/golang/protobuf/ptypes/timestamp"
-import _ "github.com/golang/protobuf/ptypes/wrappers"
-
import (
- context "golang.org/x/net/context"
+ context "context"
+ fmt "fmt"
+ pipeline_v1
"github.com/apache/beam/sdks/go/pkg/beam/model/pipeline_v1"
+ proto "github.com/golang/protobuf/proto"
+ _ "github.com/golang/protobuf/protoc-gen-go/descriptor"
+ timestamp "github.com/golang/protobuf/ptypes/timestamp"
+ _ "github.com/golang/protobuf/ptypes/wrappers"
grpc "google.golang.org/grpc"
+ codes "google.golang.org/grpc/codes"
+ status "google.golang.org/grpc/status"
+ math "math"
)
// Reference imports to suppress errors if they are not otherwise used.
@@ -25,7 +26,7 @@ var _ = math.Inf
// is compatible with the proto package it is being compiled against.
// A compilation error at this line likely means your copy of the
// proto package needs to be updated.
-const _ = proto.ProtoPackageIsVersion2 // please upgrade the proto package
+const _ = proto.ProtoPackageIsVersion3 // please upgrade the proto package
```
...
Also worth mentioning I get this during the code generation:
```
beam_fn_api.proto:45:1: warning: Import google/protobuf/wrappers.proto but
not used.
beam_fn_api.proto:43:1: warning: Import google/protobuf/descriptor.proto but
not used.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 304532)
Time Spent: 11h 50m (was: 11h 40m)
> Implement cross-bundle state caching.
> -------------------------------------
>
> Key: BEAM-5428
> URL: https://issues.apache.org/jira/browse/BEAM-5428
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Robert Bradshaw
> Assignee: Rakesh Kumar
> Priority: Major
> Time Spent: 11h 50m
> Remaining Estimate: 0h
>
> Tech spec:
> [https://docs.google.com/document/d/1BOozW0bzBuz4oHJEuZNDOHdzaV5Y56ix58Ozrqm2jFg/edit#heading=h.7ghoih5aig5m]
> Relevant document:
> [https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit#|https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit]
> Mailing list link:
> [https://lists.apache.org/thread.html/caa8d9bc6ca871d13de2c5e6ba07fdc76f85d26497d95d90893aa1f6@%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
