[
https://issues.apache.org/jira/browse/BEAM-5428?focusedWorklogId=304654&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-304654
]
ASF GitHub Bot logged work on BEAM-5428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/19 22:39
Start Date: 30/Aug/19 22:39
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9374: [BEAM-5428]
Implement Runner support for cache tokens
URL: https://github.com/apache/beam/pull/9374#discussion_r319690110
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
##########
@@ -248,31 +250,37 @@ private StateRequestHandler
getStateRequestHandler(ExecutableStage executableSta
return StateRequestHandlers.delegateBasedUponType(handlerMap);
}
- private static class BagUserStateFactory<K extends ByteString, V, W extends
BoundedWindow>
+ static class BagUserStateFactory<K extends ByteString, V, W extends
BoundedWindow>
implements StateRequestHandlers.BagUserStateHandlerFactory<K, V, W> {
private final StateInternals stateInternals;
private final KeyedStateBackend<ByteBuffer> keyedStateBackend;
private final Lock stateBackendLock;
+ /** Holds the current valid cache token for this operator. */
+ private final ByteString cacheToken;
- private BagUserStateFactory(
+ BagUserStateFactory(
StateInternals stateInternals,
KeyedStateBackend<ByteBuffer> keyedStateBackend,
Lock stateBackendLock) {
this.stateInternals = stateInternals;
this.keyedStateBackend = keyedStateBackend;
this.stateBackendLock = stateBackendLock;
+ this.cacheToken = ByteString.copyFrom(UUID.randomUUID().toString(),
Charsets.UTF_8);
Review comment:
nit: Please take in an `IdGenerator` as a parameter since it will allow one
to explicitly test knowing what the cache token value(s) will be. Also consider
using `IdGenerators#incrementingLongs`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 304654)
Time Spent: 12.5h (was: 12h 20m)
> Implement cross-bundle state caching.
> -------------------------------------
>
> Key: BEAM-5428
> URL: https://issues.apache.org/jira/browse/BEAM-5428
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Robert Bradshaw
> Assignee: Rakesh Kumar
> Priority: Major
> Time Spent: 12.5h
> Remaining Estimate: 0h
>
> Tech spec:
> [https://docs.google.com/document/d/1BOozW0bzBuz4oHJEuZNDOHdzaV5Y56ix58Ozrqm2jFg/edit#heading=h.7ghoih5aig5m]
> Relevant document:
> [https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit#|https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit]
> Mailing list link:
> [https://lists.apache.org/thread.html/caa8d9bc6ca871d13de2c5e6ba07fdc76f85d26497d95d90893aa1f6@%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
