[
https://issues.apache.org/jira/browse/BEAM-5428?focusedWorklogId=306886&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-306886
]
ASF GitHub Bot logged work on BEAM-5428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Sep/19 04:33
Start Date: 05/Sep/19 04:33
Worklog Time Spent: 10m
Work Description: tweise commented on pull request #9418: [BEAM-5428]
Implement cross-bundle user state caching in the Python SDK
URL: https://github.com/apache/beam/pull/9418#discussion_r321068479
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker.py
##########
@@ -51,7 +53,7 @@ class SdkHarness(object):
def __init__(
self, control_address, worker_count, credentials=None, worker_id=None,
- profiler_factory=None):
+ state_cache_size=100, profiler_factory=None):
Review comment:
Does this mean we can only cache 100 keys? That may be a bit little, but
probably it is best left to the user. How about making the default 0 and have
that turn the cross bundle caching off?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 306886)
Time Spent: 16h 20m (was: 16h 10m)
> Implement cross-bundle state caching.
> -------------------------------------
>
> Key: BEAM-5428
> URL: https://issues.apache.org/jira/browse/BEAM-5428
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Robert Bradshaw
> Assignee: Rakesh Kumar
> Priority: Major
> Time Spent: 16h 20m
> Remaining Estimate: 0h
>
> Tech spec:
> [https://docs.google.com/document/d/1BOozW0bzBuz4oHJEuZNDOHdzaV5Y56ix58Ozrqm2jFg/edit#heading=h.7ghoih5aig5m]
> Relevant document:
> [https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit#|https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit]
> Mailing list link:
> [https://lists.apache.org/thread.html/caa8d9bc6ca871d13de2c5e6ba07fdc76f85d26497d95d90893aa1f6@%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
