[
https://issues.apache.org/jira/browse/BEAM-5428?focusedWorklogId=307162&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307162
]
ASF GitHub Bot logged work on BEAM-5428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Sep/19 13:58
Start Date: 05/Sep/19 13:58
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #9418: [BEAM-5428]
Implement cross-bundle user state caching in the Python SDK
URL: https://github.com/apache/beam/pull/9418#discussion_r321280832
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker.py
##########
@@ -51,7 +53,7 @@ class SdkHarness(object):
def __init__(
self, control_address, worker_count, credentials=None, worker_id=None,
- profiler_factory=None):
+ state_cache_size=100, profiler_factory=None):
Review comment:
>Does this mean we can only cache 100 keys?
Yes.
>How about making the default 0 and have that turn the cross bundle caching
off?
Was thinking about this as well. Seems fair to default to 0 in the beginning
but IMHO we should change the default to cached after experimentation. Would
still keep caching enabled for the tests, except for the test suite which
explicitly has caching disabled.
>The cache size setting would need to be passed to the entry point as
pipeline option
You can read my mind. Just added this in another commit :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 307162)
Time Spent: 17h 20m (was: 17h 10m)
> Implement cross-bundle state caching.
> -------------------------------------
>
> Key: BEAM-5428
> URL: https://issues.apache.org/jira/browse/BEAM-5428
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Robert Bradshaw
> Assignee: Rakesh Kumar
> Priority: Major
> Time Spent: 17h 20m
> Remaining Estimate: 0h
>
> Tech spec:
> [https://docs.google.com/document/d/1BOozW0bzBuz4oHJEuZNDOHdzaV5Y56ix58Ozrqm2jFg/edit#heading=h.7ghoih5aig5m]
> Relevant document:
> [https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit#|https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit]
> Mailing list link:
> [https://lists.apache.org/thread.html/caa8d9bc6ca871d13de2c5e6ba07fdc76f85d26497d95d90893aa1f6@%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
