[
https://issues.apache.org/jira/browse/BEAM-8100?focusedWorklogId=307856&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307856
]
ASF GitHub Bot logged work on BEAM-8100:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Sep/19 13:37
Start Date: 06/Sep/19 13:37
Worklog Time Spent: 10m
Work Description: jklukas commented on pull request #9499: [BEAM-8100]
Exception handling for AsJsons and ParseJsons
URL: https://github.com/apache/beam/pull/9499#discussion_r321736061
##########
File path:
sdks/java/extensions/jackson/src/main/java/org/apache/beam/sdk/extensions/jackson/AsJsons.java
##########
@@ -56,6 +63,35 @@ private AsJsons(Class<? extends InputT> outputClass) {
return newTransform;
}
+ /**
+ * Returns a new {@link AsJsonsWithFailures} transform that catches
exceptions raised while
+ * writing JSON elements, passing the raised exception instance and the
input element being
+ * processed through the given {@code exceptionHandler} and emitting the
result to a failure
+ * collection.
+ *
+ * <p>Example usage:
+ *
+ * <pre>{@code
+ * WithFailures.Result<PCollection<String>, KV<MyPojo, Map<String, String>>>
result =
+ * pojos.apply(
+ * AsJsons.of(MyPojo.class)
+ * .withFailures(new
WithFailures.ExceptionAsMapHandler<MyPojo>() {}));
+ *
+ * PCollection<String> output = result.output(); // valid json elements
+ * PCollection<KV<MyPojo, Map<String, String>>> failures = result.failures();
+ * }</pre>
+ */
+ @Experimental(Experimental.Kind.WITH_EXCEPTIONS)
+ public <FailureT> AsJsonsWithFailures<FailureT> withFailures(
Review comment:
And perhaps these JSON cases are constrained enough that we could provide a
default exceptionHandler so that the user doesn't need to specify one. Perhaps
it would catch only the exceptions we expect to be raised
(`JsonProcessingException` for AsJsons and `IOException` for ParseJsons),
reraising an other exceptions, and return a KV that contains the input element
along with a string containing the exception message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 307856)
Time Spent: 1h (was: 50m)
> Add exception handling to Json transforms in Java SDK
> -----------------------------------------------------
>
> Key: BEAM-8100
> URL: https://issues.apache.org/jira/browse/BEAM-8100
> Project: Beam
> Issue Type: Improvement
> Components: extensions-java-json, sdk-java-core
> Reporter: Jeff Klukas
> Assignee: Alexey Romanenko
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Follow-up to https://issues.apache.org/jira/browse/BEAM-5638. We have
> exception handling for MapElements and FlatMapElements. It should be
> straightforward to add parallel signatures to AsJsons and ParseJsons for
> catching parsing errors.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
