[
https://issues.apache.org/jira/browse/BEAM-8100?focusedWorklogId=316764&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316764
]
ASF GitHub Bot logged work on BEAM-8100:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/19 16:06
Start Date: 23/Sep/19 16:06
Worklog Time Spent: 10m
Work Description: jklukas commented on issue #9499: [BEAM-8100] Exception
handling for AsJsons and ParseJsons
URL: https://github.com/apache/beam/pull/9499#issuecomment-534158013
I'm having a realization that we could probably avoid most of the complexity
here if `ParseJsons` simply returned the `MapElements` transform it builds
rather than wrapping it. I don't think that's particularly an option since
users already have code that expects an object of type `ParseJsons`, but what
if we exposed a method to return the underlying `MapElements` so that users
could call the existing error handling methods? It might look like:
```
PCollection<String> p = ...
p.apply(ParseJsons
.of(MyClass.class)
.unwrapped()
.exceptionsVia(...))
```
This is slightly less convenient for the user, as they have to know about
and invoke the `unwrapped` method (we can probably come up with a better name,
(`toMap`, `asMap`, `asMapElements`)?), but it avoids us having to re-implement
all the logic from `MapElements` and it would establish a pattern by which
other simple transforms that wrap a `MapElements` invocation could provide
error handling.
What do you think of that approach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 316764)
Time Spent: 2h 20m (was: 2h 10m)
> Add exception handling to Json transforms in Java SDK
> -----------------------------------------------------
>
> Key: BEAM-8100
> URL: https://issues.apache.org/jira/browse/BEAM-8100
> Project: Beam
> Issue Type: Improvement
> Components: extensions-java-json, sdk-java-core
> Reporter: Jeff Klukas
> Assignee: Alexey Romanenko
> Priority: Minor
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Follow-up to https://issues.apache.org/jira/browse/BEAM-5638. We have
> exception handling for MapElements and FlatMapElements. It should be
> straightforward to add parallel signatures to AsJsons and ParseJsons for
> catching parsing errors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
