[ 
https://issues.apache.org/jira/browse/BEAM-6185?focusedWorklogId=308266&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308266
 ]

ASF GitHub Bot logged work on BEAM-6185:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Sep/19 02:33
            Start Date: 07/Sep/19 02:33
    Worklog Time Spent: 10m 
      Work Description: aaltay commented on pull request #9487: 
[BEAM-6185]Change default docker images name
URL: https://github.com/apache/beam/pull/9487#discussion_r321951929
 
 

 ##########
 File path: sdks/python/apache_beam/runners/portability/portable_runner.py
 ##########
 @@ -84,13 +84,12 @@ def default_docker_image():
                       'has Python %d.%d interpreter.' % (
                           sys.version_info[0], sys.version_info[1]))
 
-      # Perhaps also test if this was built?
-      image = ('{user}-docker-apache.bintray.io/beam/python'
-               '{version_suffix}:latest'.format(
-                   user=os.environ['USER'],
-                   version_suffix=version_suffix))
+      image = ('apachebeam/python{version_suffix}_sdk:latest'.format(
 
 Review comment:
   To build on Thomas's idea, we could do something similar to what 
dataflowrunner does today 
(https://github.com/apache/beam/blob/9043b3e0bc138e63123d3fa55d4b7280eb96a82e/sdks/python/apache_beam/runners/dataflow/internal/apiclient.py#L946)
   
   - If this is a released version on release branch (i.e. no 'dev' in 
version') default to image in hub. (release manager will have to build this 
container as part of the release anyway.)
   - If it is a dev version --> this is a question. Dataflowrunner's solution 
is to have a fixed image that is occasionally updated as needed or if provided 
a flag use that as an override. (Here we might just simplify and require a 
locally built version. This occasionally built image is convenient but is 
error-prone and a hassle.)
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 308266)
    Time Spent: 3h 10m  (was: 3h)

> Upgrade Spark to version 2.4.0
> ------------------------------
>
>                 Key: BEAM-6185
>                 URL: https://issues.apache.org/jira/browse/BEAM-6185
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-spark
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>            Priority: Major
>             Fix For: 2.12.0
>
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to