[
https://issues.apache.org/jira/browse/BEAM-6185?focusedWorklogId=308285&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308285
]
ASF GitHub Bot logged work on BEAM-6185:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Sep/19 03:34
Start Date: 07/Sep/19 03:34
Worklog Time Spent: 10m
Work Description: Hannah-Jiang commented on pull request #9487:
[BEAM-6185]Change default docker images name
URL: https://github.com/apache/beam/pull/9487#discussion_r321953571
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -84,13 +84,12 @@ def default_docker_image():
'has Python %d.%d interpreter.' % (
sys.version_info[0], sys.version_info[1]))
- # Perhaps also test if this was built?
- image = ('{user}-docker-apache.bintray.io/beam/python'
- '{version_suffix}:latest'.format(
- user=os.environ['USER'],
- version_suffix=version_suffix))
+ image = ('apachebeam/python{version_suffix}_sdk:latest'.format(
Review comment:
Thanks @aaltay and @tweise for comments.
`--environment_config` option can be used to pass customized images when use
Portable runner. The default image is used when no docker image is specified.
My understanding is, from users perspective, they don't need to worry about
creating docker images at local when they write pipelines, so it's ok to pull
it from remote. From developers perspective, developers who are working on sdks
are expected to know how portable runner is working, so as how docker is used.
If they want to test their developing sdks, they should build an image at local
and use it. The image name can be same as the default one, then the local image
is used instead of pulling it from remote, or can pass it with
`--environment_config` option if it has different name.
I can add more comments here to explain how to pass customized images.
What scenarios am I missing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 308285)
Time Spent: 3h 20m (was: 3h 10m)
> Upgrade Spark to version 2.4.0
> ------------------------------
>
> Key: BEAM-6185
> URL: https://issues.apache.org/jira/browse/BEAM-6185
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 2.12.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
