[
https://issues.apache.org/jira/browse/BEAM-7013?focusedWorklogId=309924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309924
]
ASF GitHub Bot logged work on BEAM-7013:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/19 15:57
Start Date: 10/Sep/19 15:57
Worklog Time Spent: 10m
Work Description: zfraa commented on pull request #9519: [BEAM-7013] Use
a 0-length byte array to represent empty sketch in HllCount
URL: https://github.com/apache/beam/pull/9519#discussion_r322661239
##########
File path:
sdks/java/extensions/zetasketch/src/main/java/org/apache/beam/sdk/extensions/zetasketch/HllCount.java
##########
@@ -237,10 +240,11 @@ private Builder(HllCountInitFn<InputT, ?> initFn) {
* PCollection<InputT>} and returns a {@code PCollection<byte[]>} which
consists of the HLL++
* sketch computed from the elements in the input {@code PCollection}.
*
- * <p>Returns an empty output {@code PCollection} if the input {@code
PCollection} is empty.
+ * <p>Returns a singleton {@code PCollection} with an "empty sketch"
(0-length byte array) if
+ * the input {@code PCollection} is empty.
Review comment:
Could you add the same comment to the perKey method below? Or does a perKey
aggregation work exactly like a group-by, i.e., it can never be associated with
an empty aggregation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 309924)
Time Spent: 32h (was: 31h 50m)
> A new count distinct transform based on BigQuery compatible HyperLogLog++
> implementation
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-7013
> URL: https://issues.apache.org/jira/browse/BEAM-7013
> Project: Beam
> Issue Type: New Feature
> Components: extensions-java-sketching, sdk-java-core
> Reporter: Yueyang Qiu
> Assignee: Yueyang Qiu
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 32h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
