[
https://issues.apache.org/jira/browse/BEAM-7013?focusedWorklogId=309922&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309922
]
ASF GitHub Bot logged work on BEAM-7013:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/19 15:57
Start Date: 10/Sep/19 15:57
Worklog Time Spent: 10m
Work Description: zfraa commented on pull request #9519: [BEAM-7013] Use
a 0-length byte array to represent empty sketch in HllCount
URL: https://github.com/apache/beam/pull/9519#discussion_r322657271
##########
File path:
sdks/java/extensions/zetasketch/src/main/java/org/apache/beam/sdk/extensions/zetasketch/HllCountMergePartialFn.java
##########
@@ -54,10 +54,15 @@ private HllCountMergePartialFn() {}
return null;
}
+ @Nullable
@Override
public HyperLogLogPlusPlus<HllT> addInput(
@Nullable HyperLogLogPlusPlus<HllT> accumulator, byte[] input) {
Review comment:
Let's leave things as they are in this PR, so that this can be merged!
Whether we should do any follow-ups: I would lean towards avoiding user
errors, since every error avoided is something that users don't need to revise
their pipeline over, and is an issue that is not escalated to us. Also, if
users need to filter their input and replace nulls with byte[0], is that
streamed (resp. folded into another pass over the data) or does it result in an
extra-pass over the data?
But I don't feel strongly about it and I'll let you make the call, and as
you say, we can always change it later if there's a need for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 309922)
> A new count distinct transform based on BigQuery compatible HyperLogLog++
> implementation
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-7013
> URL: https://issues.apache.org/jira/browse/BEAM-7013
> Project: Beam
> Issue Type: New Feature
> Components: extensions-java-sketching, sdk-java-core
> Reporter: Yueyang Qiu
> Assignee: Yueyang Qiu
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 31h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
