[
https://issues.apache.org/jira/browse/BEAM-3713?focusedWorklogId=310033&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310033
]
ASF GitHub Bot logged work on BEAM-3713:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/19 18:53
Start Date: 10/Sep/19 18:53
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #9514: [BEAM-3713]
Convert ITs to not use save_main_session
URL: https://github.com/apache/beam/pull/9514#discussion_r322907708
##########
File path: sdks/python/apache_beam/examples/complete/distribopt.py
##########
@@ -314,7 +314,7 @@ def format_output(element):
return result
-def run(argv=None):
+def run(argv=None, save_main_session=True):
Review comment:
Can we determine this instead of adding a parameter? Since this change
affects examples, I am worried that users will transfer this pattern into their
pipelines (or will have to reason whether they should), and it might be
unnecessary complication.
Perhaps we could:
```
# Explain why we do this, where it's not explained
pipeline_options.view_as(SetupOptions).save_main_session = __name__ ==
'__main__'
```
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 310033)
Time Spent: 5h 50m (was: 5h 40m)
> Consider moving away from nose to nose2 or pytest.
> --------------------------------------------------
>
> Key: BEAM-3713
> URL: https://issues.apache.org/jira/browse/BEAM-3713
> Project: Beam
> Issue Type: Test
> Components: sdk-py-core, testing
> Reporter: Robert Bradshaw
> Assignee: Udi Meiri
> Priority: Minor
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> Per
> [https://nose.readthedocs.io/en/latest/|https://nose.readthedocs.io/en/latest/,]
> , nose is in maintenance mode.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
