[
https://issues.apache.org/jira/browse/BEAM-3713?focusedWorklogId=310184&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310184
]
ASF GitHub Bot logged work on BEAM-3713:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/19 23:36
Start Date: 10/Sep/19 23:36
Worklog Time Spent: 10m
Work Description: udim commented on pull request #9514: [BEAM-3713]
Convert ITs to not use save_main_session
URL: https://github.com/apache/beam/pull/9514#discussion_r323006012
##########
File path: sdks/python/apache_beam/examples/complete/distribopt.py
##########
@@ -314,7 +314,7 @@ def format_output(element):
return result
-def run(argv=None):
+def run(argv=None, save_main_session=True):
Review comment:
I think the best solution would be to remove save_main_session from examples
altogether, even if that means splitting them into 2 modules. Since that is out
of scope for the item I'm working on, I opted for the solution I proposed. I
believe my solution is necessary and simpler than checking the magic variable
`__name__`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 310184)
Time Spent: 6h (was: 5h 50m)
> Consider moving away from nose to nose2 or pytest.
> --------------------------------------------------
>
> Key: BEAM-3713
> URL: https://issues.apache.org/jira/browse/BEAM-3713
> Project: Beam
> Issue Type: Test
> Components: sdk-py-core, testing
> Reporter: Robert Bradshaw
> Assignee: Udi Meiri
> Priority: Minor
> Time Spent: 6h
> Remaining Estimate: 0h
>
> Per
> [https://nose.readthedocs.io/en/latest/|https://nose.readthedocs.io/en/latest/,]
> , nose is in maintenance mode.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
