[
https://issues.apache.org/jira/browse/BEAM-8165?focusedWorklogId=310091&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310091
]
ASF GitHub Bot logged work on BEAM-8165:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/19 20:37
Start Date: 10/Sep/19 20:37
Worklog Time Spent: 10m
Work Description: Hannah-Jiang commented on issue #9487:
[BEAM-8165]Change default docker images name
URL: https://github.com/apache/beam/pull/9487#issuecomment-530109210
> `project.version` does not match Python version in master branch. It will
be `2.16.0-SNAPSHOT` vs `2.16.0.dev`. I am guessing we can still use it and
with a simple string raplace change '-SNAPSHOT' to '.dev' for python.
I also investigated this option during weekend and there is a scenarios we
cannot support with string replacement.
For released versions, it would be `{version}-SNAPSHOT` at
`gradle.properties`, but `{version}` at `version.py`. So if a user build an
image from released version, it would be tagged with `{version}.dev`, however,
an image with `{version}` tag will be used as a default image, which would make
difficult to investigate for users who are not familiar with how tagging works
with Beam.
This is the same issue as I mentioned previously, given
`{version}-SNAPSHOT`, we cannot tell if it's developing version or released
version. I also tried to change `{version}-SNAPSHOT` to `{version}` for
released versions, and `{version}.dev` for developing versions, but 2.16 cutoff
date is so close and the impact with the change would be wide, so I decided to
introduce a new variable for now and make the change later.
We have the version defined at several different locations and suffixes are
not consistent, which should be improved. I changed scope of [the Jira
ticket](https://issues.apache.org/jira/browse/BEAM-8192) to include this work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 310091)
Time Spent: 2h 10m (was: 2h)
> Change image name and add images to release process
> ---------------------------------------------------
>
> Key: BEAM-8165
> URL: https://issues.apache.org/jira/browse/BEAM-8165
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go, sdk-java-harness, sdk-py-harness
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> change name to apachebeam/\{lang}{ver}_sdk
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
