[
https://issues.apache.org/jira/browse/BEAM-8165?focusedWorklogId=310095&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310095
]
ASF GitHub Bot logged work on BEAM-8165:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/19 20:45
Start Date: 10/Sep/19 20:45
Worklog Time Spent: 10m
Work Description: Hannah-Jiang commented on pull request #9487:
[BEAM-8165]Change default docker images name
URL: https://github.com/apache/beam/pull/9487#discussion_r322953450
##########
File path: sdks/python/container/py2/build.gradle
##########
@@ -51,8 +52,13 @@ task copyLauncherDependencies(type: Copy) {
}
}
+def sdk_version = '2.16.0'
Review comment:
Thanks for reviewing and comments.
I wanted to make `sdk_version` consistent with the one from `version.py`,
forgot to change it back after testing. Thanks for catching it.
After evaluating many options, I think introducing a new variable
`sdk_version` to `gradle.properties` is the easiest way for now. This version
will be consistent to the one from `version.py`, so we need to update it when
we release it. It would be better to read it from `version.py` and assign to
`sdk_version`, however, as far as I know, `gradle.properties` is not supposed
to read variables from another file. If it's possible, I am happy to try.
I made a commit with this change, can you please review and make comments?
Thanks,
Hannah
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 310095)
Time Spent: 2h 20m (was: 2h 10m)
> Change image name and add images to release process
> ---------------------------------------------------
>
> Key: BEAM-8165
> URL: https://issues.apache.org/jira/browse/BEAM-8165
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go, sdk-java-harness, sdk-py-harness
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> change name to apachebeam/\{lang}{ver}_sdk
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
