[
https://issues.apache.org/jira/browse/BEAM-8240?focusedWorklogId=313177&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-313177
]
ASF GitHub Bot logged work on BEAM-8240:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Sep/19 17:05
Start Date: 16/Sep/19 17:05
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #9583: [BEAM-8240]
Ensure that the pipeline proto contains the worker_harness_container_image
override
URL: https://github.com/apache/beam/pull/9583#discussion_r324785305
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -383,7 +383,7 @@ def run_pipeline(self, pipeline, options):
use_fnapi = apiclient._use_fnapi(options)
from apache_beam.portability.api import beam_runner_api_pb2
default_container_image = (
Review comment:
Maybe do not call this variable "default"_container_image any more, since it
not really just default.
Alternatively, we can remove the variable and change L390 to read
`container_image=apiclient.get_container_image_from_options(options)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 313177)
Time Spent: 1h 10m (was: 1h)
> SDK Harness
> -----------
>
> Key: BEAM-8240
> URL: https://issues.apache.org/jira/browse/BEAM-8240
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-harness
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> SDK harness incorrectly identifies itself when using custom SDK container
> within environment field when building pipeline proto.
>
> Passing in the experiment *worker_harness_container_image=YYY* doesn't
> override the pipeline proto environment field and it is still being populated
> with *gcr.io/cloud-dataflow/v1beta3/python-fnapi:beam-master-20190802*
>
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
