[
https://issues.apache.org/jira/browse/BEAM-8240?focusedWorklogId=313185&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-313185
]
ASF GitHub Bot logged work on BEAM-8240:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Sep/19 17:12
Start Date: 16/Sep/19 17:12
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9583: [BEAM-8240]
Ensure that the pipeline proto contains the worker_harness_container_image
override
URL: https://github.com/apache/beam/pull/9583#discussion_r324788086
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -908,15 +904,18 @@ def _get_container_image_tag():
return base_version
-def get_default_container_image_for_current_sdk(use_fnapi):
+def get_container_image_from_options(pipeline_options):
"""For internal use only; no backwards-compatibility guarantees.
Args:
- use_fnapi (bool): True, if pipeline is using FnAPI, False otherwise.
+ pipeline_options (PipelineOptions): A container for pipeline options.
Returns:
- str: Google Cloud Dataflow container image for remote execution.
+ str: Container image for remote execution.
"""
+ if pipeline_options.As(WorkerOptions).worker_harness_container_image:
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 313185)
Time Spent: 1h 50m (was: 1h 40m)
> SDK Harness
> -----------
>
> Key: BEAM-8240
> URL: https://issues.apache.org/jira/browse/BEAM-8240
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-harness
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> SDK harness incorrectly identifies itself when using custom SDK container
> within environment field when building pipeline proto.
>
> Passing in the experiment *worker_harness_container_image=YYY* doesn't
> override the pipeline proto environment field and it is still being populated
> with *gcr.io/cloud-dataflow/v1beta3/python-fnapi:beam-master-20190802*
>
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
