[
https://issues.apache.org/jira/browse/BEAM-5428?focusedWorklogId=317746&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317746
]
ASF GitHub Bot logged work on BEAM-5428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Sep/19 18:39
Start Date: 24/Sep/19 18:39
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9374: [BEAM-5428]
Implement Runner support for cache tokens
URL: https://github.com/apache/beam/pull/9374#discussion_r327773025
##########
File path:
runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/SdkHarnessClientTest.java
##########
@@ -574,6 +579,41 @@ public void
handleCleanupWithStateWhenAwaitingOnClosingOutputReceivers() throws
}
}
+ @Test
+ public void verifyCacheTokensAreUsedInNewBundleRequest() {
+ CompletableFuture<InstructionResponse> registerResponseFuture = new
CompletableFuture<>();
+ when(fnApiControlClient.handle(any(BeamFnApi.InstructionRequest.class)))
+ .thenReturn(registerResponseFuture);
+
+ ProcessBundleDescriptor descriptor1 =
+ ProcessBundleDescriptor.newBuilder().setId("descriptor1").build();
+
+ Map<String, RemoteInputDestination<WindowedValue<?>>> remoteInputs =
+ Collections.singletonMap(
+ "inputPC",
+ RemoteInputDestination.of(
+ (FullWindowedValueCoder)
+ FullWindowedValueCoder.of(VarIntCoder.of(),
GlobalWindow.Coder.INSTANCE),
+ SDK_GRPC_READ_TRANSFORM));
+
+ BundleProcessor processor1 = sdkHarnessClient.getProcessor(descriptor1,
remoteInputs);
+ when(dataService.send(any(),
any())).thenReturn(mock(CloseableFnDataReceiver.class));
+
+ StateRequestHandler stateRequestHandler =
Mockito.mock(StateRequestHandler.class);
+ List<BeamFnApi.ProcessBundleRequest.CacheToken> cacheTokens =
+ Collections.singletonList(
+
BeamFnApi.ProcessBundleRequest.CacheToken.newBuilder().getDefaultInstanceForType());
+ when(stateRequestHandler.getCacheTokens()).thenReturn(cacheTokens);
+
+ processor1.newBundle(
+ ImmutableMap.of(SDK_GRPC_WRITE_TRANSFORM,
mock(RemoteOutputReceiver.class)),
+ stateRequestHandler,
+ BundleProgressHandler.ignored());
+
+ // Verify that the cache token list is retrieved from the state handler
+ Mockito.verify(stateRequestHandler).getCacheTokens();
Review comment:
We should be checking that the mock FnApiControlClient got a ProcessBundle
InstructionRequest with the cache token specified and not verifying that the
state request handler was invoked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 317746)
> Implement cross-bundle state caching.
> -------------------------------------
>
> Key: BEAM-5428
> URL: https://issues.apache.org/jira/browse/BEAM-5428
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Robert Bradshaw
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 19h 50m
> Remaining Estimate: 0h
>
> Tech spec:
> [https://docs.google.com/document/d/1BOozW0bzBuz4oHJEuZNDOHdzaV5Y56ix58Ozrqm2jFg/edit#heading=h.7ghoih5aig5m]
> Relevant document:
> [https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit#|https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit]
> Mailing list link:
> [https://lists.apache.org/thread.html/caa8d9bc6ca871d13de2c5e6ba07fdc76f85d26497d95d90893aa1f6@%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
