[
https://issues.apache.org/jira/browse/BEAM-5428?focusedWorklogId=318997&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318997
]
ASF GitHub Bot logged work on BEAM-5428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Sep/19 14:48
Start Date: 26/Sep/19 14:48
Worklog Time Spent: 10m
Work Description: tweise commented on pull request #9418: [BEAM-5428]
Implement cross-bundle user state caching in the Python SDK
URL: https://github.com/apache/beam/pull/9418#discussion_r328658157
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner_test.py
##########
@@ -201,7 +204,8 @@ class
PortableRunnerTestWithExternalEnv(PortableRunnerTest):
@classmethod
def setUpClass(cls):
cls._worker_address, cls._worker_server = (
- worker_pool_main.BeamFnExternalWorkerPoolServicer.start())
+ worker_pool_main.BeamFnExternalWorkerPoolServicer.start(
Review comment:
Logically this is duplicates the experiment flag above. I can see why that
is currently necessary, but maybe it would be better to provide the pipeline
options to the worker pool servicer? (Inside the container this would happen
via provisioning endpoint and environment.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 318997)
Time Spent: 21h 40m (was: 21.5h)
> Implement cross-bundle state caching.
> -------------------------------------
>
> Key: BEAM-5428
> URL: https://issues.apache.org/jira/browse/BEAM-5428
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Robert Bradshaw
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 21h 40m
> Remaining Estimate: 0h
>
> Tech spec:
> [https://docs.google.com/document/d/1BOozW0bzBuz4oHJEuZNDOHdzaV5Y56ix58Ozrqm2jFg/edit#heading=h.7ghoih5aig5m]
> Relevant document:
> [https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit#|https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit]
> Mailing list link:
> [https://lists.apache.org/thread.html/caa8d9bc6ca871d13de2c5e6ba07fdc76f85d26497d95d90893aa1f6@%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
