[ 
https://issues.apache.org/jira/browse/BEAM-8162?focusedWorklogId=319419&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319419
 ]

ASF GitHub Bot logged work on BEAM-8162:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Sep/19 09:02
            Start Date: 27/Sep/19 09:02
    Worklog Time Spent: 10m 
      Work Description: sunjincheng121 commented on issue #9464: [BEAM-8162] 
Encode keys as NESTED for flink keyselector
URL: https://github.com/apache/beam/pull/9464#issuecomment-535857475
 
 
   Great thanks for your remind @dmvk! 
   
   I seriously looked at the changes in #9484(already merged). I found that the 
changes to the Java side are essentially the same as my current PR, so until 
now I still think there is no problem with the solution in my PR. Merging this 
PR is no problem. We can always improve or fix some code if reviewer have any 
concern. So, I think that it is not necessary to revert this PR.  I will add 
more comments on the #9484. 
   
   Best,
   Jincheng
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 319419)
    Time Spent: 1.5h  (was: 1h 20m)

> NPE error when add flink 1.9 runner
> -----------------------------------
>
>                 Key: BEAM-8162
>                 URL: https://issues.apache.org/jira/browse/BEAM-8162
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>            Priority: Major
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> When add flink 1.9 runner in https://github.com/apache/beam/pull/9296, we 
> find an NPE error when run the `PortableTimersExecutionTest`. 
> the detail can be found here: 
> https://github.com/apache/beam/pull/9296#issuecomment-525262607



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to