[
https://issues.apache.org/jira/browse/BEAM-8162?focusedWorklogId=320189&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320189
]
ASF GitHub Bot logged work on BEAM-8162:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/19 10:48
Start Date: 29/Sep/19 10:48
Worklog Time Spent: 10m
Work Description: sunjincheng121 commented on issue #9464: [BEAM-8162]
Encode keys as NESTED for flink keyselector
URL: https://github.com/apache/beam/pull/9464#issuecomment-536282790
Hi @mxm, thanks for your reply. I am glad to share my thoughts as follows:
1) We can create a JIRA if there is no JIRA number. This is also mentioned
by @dmvk.
Actually I find that there are many commits without JIRA numbers in Beam, so
I don't think this is a strong reason to revert a commit.
(BTW, this PR is helping @dmvk to fix BEAM-7730's PR issue:
https://github.com/apache/beam/pull/9296#issuecomment-525262607).
2) Regarding to breaking the Python part, the tests already passed when
merging this PR and so we didn't find this problem.Besides, as this commit
doesn't break the master tests and will not block other contributors, so we
have enough time to fix the Python part if we find that it is broken. So we
have other better choices instead of reverting the commit.
3) Regarding to the changes to fix the Python problem on top of this PR, I
think less changes are needed and only need add `encode_nested` and
`decode_nested` in `coder.py` and `bundle_processor.py` for using the
`encode_nested`(It's very clear in your PR). In this way, we can not only solve
this problem, but also encourage contributors and committers.
BTW, not all the new contributors know the rules of Beam well. We should
have a better way to correct the mistakes of new contributors. Reverting is not
the only way, nor the best way.
I believe we have the same goal: to find a better way to make contributors
happy to contribute to the Beam community.
So I just share my thoughts not only for this PR but also for how to deal
with same kinds of problems in the future.
Great thanks for affirmation of my contribution. Feel free to correct me if
there are anything incorrect.
Best,
Jincheng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 320189)
Time Spent: 1h 50m (was: 1h 40m)
> NPE error when add flink 1.9 runner
> -----------------------------------
>
> Key: BEAM-8162
> URL: https://issues.apache.org/jira/browse/BEAM-8162
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> When add flink 1.9 runner in https://github.com/apache/beam/pull/9296, we
> find an NPE error when run the `PortableTimersExecutionTest`.
> the detail can be found here:
> https://github.com/apache/beam/pull/9296#issuecomment-525262607
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
