[
https://issues.apache.org/jira/browse/BEAM-8157?focusedWorklogId=319495&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319495
]
ASF GitHub Bot logged work on BEAM-8157:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/19 11:40
Start Date: 27/Sep/19 11:40
Worklog Time Spent: 10m
Work Description: mxm commented on issue #9484: [BEAM-8157] Ensure key
encoding for state requests is consistent across SDKs
URL: https://github.com/apache/beam/pull/9484#issuecomment-535904381
I very much appreciate your work on this @sunjincheng121. Let it be said,
your contributions are recognized. I also have to repeat that your solution in
#9464 was incomplete. Not only did it not adhere to our contribution standard
because it was originally without a JIRA ("hotfix"), but it also broke the
Python support, as our tests showed. It required careful investigation to find
out the root of the problem and to not break any other SDK as the result of a
quick fix. We could not iterate on your PR because it was already merged, so
reverting it was the only option.
The changes, while similar, are not identical. I could have based them on
your original PR, but that would have still required to do more changes, since
there are differences related to the code and the tests. I know that getting
one's commit reverted is not a good feeling. It happens to everyone eventually,
and it is not to diminish your contributors in any way. Keep up the great
contributions. I know that everyone in the Beam community greatly appreciates
your work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 319495)
Time Spent: 5h 50m (was: 5h 40m)
> Key encoding for state requests is not consistent across SDKs
> -------------------------------------------------------------
>
> Key: BEAM-8157
> URL: https://issues.apache.org/jira/browse/BEAM-8157
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Affects Versions: 2.13.0
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Fix For: 2.17.0
>
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> The Flink runner requires the internal key to be encoded without a length
> prefix (OUTER context). The user state request handler exposes a serialized
> version of the key to the Runner. This key is encoded with the NESTED context
> which may add a length prefix. We need to convert it to OUTER context to
> match the Flink runner's key encoding.
> So far this has not caused the Flink Runner to behave incorrectly. However,
> with the upcoming support for Flink 1.9, the state backend will not accept
> requests for keys not part of any key group/partition of the operator. This
> is very likely to happen with the encoding not being consistent.
> **NOTE** This is only applicable to the Java SDK, as the Python SDK uses
> OUTER encoding for the key in state requests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
