[
https://issues.apache.org/jira/browse/BEAM-8157?focusedWorklogId=319420&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319420
]
ASF GitHub Bot logged work on BEAM-8157:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/19 09:03
Start Date: 27/Sep/19 09:03
Worklog Time Spent: 10m
Work Description: sunjincheng121 commented on issue #9484: [BEAM-8157]
Ensure key encoding for state requests is consistent across SDKs
URL: https://github.com/apache/beam/pull/9484#issuecomment-535857787
Hi @mxm, Sorry for late reply. I go through the changes of this PR and found
that the solution in this PR is the same as #9464. The functionality of Java
side changes is the same as #9464. Regarding to the Python part, it's a good
catch. I think it will be better to recover the changes of #9464 and add fixes
for the Python part on top of it. I don't think it's a best way to revert the
contributions in this case. Even we revert a commit in some reason, we should
also recover it if we finally find the original solution is correct. This is a
respect for the contributors and the committers.
What do you think? @mxm @tweise @lukecwik
Best, Jincheng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 319420)
Time Spent: 5h 40m (was: 5.5h)
> Key encoding for state requests is not consistent across SDKs
> -------------------------------------------------------------
>
> Key: BEAM-8157
> URL: https://issues.apache.org/jira/browse/BEAM-8157
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Affects Versions: 2.13.0
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Fix For: 2.17.0
>
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> The Flink runner requires the internal key to be encoded without a length
> prefix (OUTER context). The user state request handler exposes a serialized
> version of the key to the Runner. This key is encoded with the NESTED context
> which may add a length prefix. We need to convert it to OUTER context to
> match the Flink runner's key encoding.
> So far this has not caused the Flink Runner to behave incorrectly. However,
> with the upcoming support for Flink 1.9, the state backend will not accept
> requests for keys not part of any key group/partition of the operator. This
> is very likely to happen with the encoding not being consistent.
> **NOTE** This is only applicable to the Java SDK, as the Python SDK uses
> OUTER encoding for the key in state requests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
