[
https://issues.apache.org/jira/browse/BEAM-8350?focusedWorklogId=323502&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323502
]
ASF GitHub Bot logged work on BEAM-8350:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Oct/19 15:59
Start Date: 04/Oct/19 15:59
Worklog Time Spent: 10m
Work Description: chadrik commented on issue #9725: [BEAM-8350] Upgrade
to Pylint 2.4
URL: https://github.com/apache/beam/pull/9725#issuecomment-538169256
Here's a breakdown of the changes required to get to pylint 2.4:
- fix a bunch of warnings about deprecated methods. mostly `logger.warn`
and various unittest methods
- update the names of a few error codes: `disable=unused-import` and
`possibly-unused-variable`
- ignore a bunch of newly introduced style warnings that did not seem
important
- run the lint on python-3.7: this ensures that it can run on test files
that only work on python-37 due to syntax features
- merge the lint tests into one test:
- `run_pylint_2to3.sh` was a test just for testing the futurization.
seems fine to do this all the time now that our code is python2 compliant
- there was a "mini" test just for python3-compatibility. not needed
anymore now that everything is running on python3
- stop running `pycodestyle`: it's run as part of `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 323502)
Time Spent: 1h 10m (was: 1h)
> Upgrade to pylint 2.4
> ---------------------
>
> Key: BEAM-8350
> URL: https://issues.apache.org/jira/browse/BEAM-8350
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> pylint 2.4 provides a number of new features and fixes, but the most
> important/pressing one for me is that 2.4 adds support for understanding
> python type annotations, which fixes a bunch of spurious unused import errors
> in the PR I'm working on for BEAM-7746.
> As of 2.0, pylint dropped support for running tests in python2, so to make
> the upgrade we have to move our lint jobs to python3. Doing so will put
> pylint into "python3-mode" and there is not an option to run in
> python2-compatible mode. That said, the beam code is intended to be python3
> compatible, so in practice, performing a python3 lint on the Beam code-base
> is perfectly safe. The primary risk of doing this is that someone introduces
> a python-3 only change that breaks python2, but these would largely be syntax
> errors that would be immediately caught by the unit and integration tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
