[
https://issues.apache.org/jira/browse/BEAM-8350?focusedWorklogId=326990&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-326990
]
ASF GitHub Bot logged work on BEAM-8350:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Oct/19 16:56
Start Date: 11/Oct/19 16:56
Worklog Time Spent: 10m
Work Description: chadrik commented on issue #9725: [BEAM-8350] Upgrade
to Pylint 2.4
URL: https://github.com/apache/beam/pull/9725#issuecomment-541142817
My argument here is that there is no practical difference to the current
approach and this new approach, other than the catching of syntax errors
which will be easily caught by unit tests. Besides, there were syntax
changes made in 3.0, 3.5 and 3.6 (and probably other versions that I’m not
aware of) and we are not currently linting these versions separately so we
aren’t effectively using linting to catch syntax problems now anyway. We
*are* testing minor versions separately with our unittests, so that will
catch syntax errors per version.
On Fri, Oct 11, 2019 at 12:30 PM Ahmet Altay <[email protected]>
wrote:
> *@aaltay* commented on this pull request.
>
> High level question, would it be better to keep py2/3 lint covered until
> py2 is officially not supported in the beam code base? Currently we do not
> exactly know when this will happen and it seems like it will be around
> December/January.
>
> Or is it possible to keep 2 lint targets?
>
> /cc @tvalentyn <https://github.com/tvalentyn>
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/beam/pull/9725?email_source=notifications&email_token=AAAPOE6GD76QSHKPC2FXQLTQOCS3LA5CNFSM4I5JLFZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHW43NY#pullrequestreview-300797367>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AAAPOE3Q5PR5SB2HB5F5I4LQOCS3LANCNFSM4I5JLFZQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 326990)
Time Spent: 3h (was: 2h 50m)
> Upgrade to pylint 2.4
> ---------------------
>
> Key: BEAM-8350
> URL: https://issues.apache.org/jira/browse/BEAM-8350
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> pylint 2.4 provides a number of new features and fixes, but the most
> important/pressing one for me is that 2.4 adds support for understanding
> python type annotations, which fixes a bunch of spurious unused import errors
> in the PR I'm working on for BEAM-7746.
> As of 2.0, pylint dropped support for running tests in python2, so to make
> the upgrade we have to move our lint jobs to python3. Doing so will put
> pylint into "python3-mode" and there is not an option to run in
> python2-compatible mode. That said, the beam code is intended to be python3
> compatible, so in practice, performing a python3 lint on the Beam code-base
> is perfectly safe. The primary risk of doing this is that someone introduces
> a python-3 only change that breaks python2, but these would largely be syntax
> errors that would be immediately caught by the unit and integration tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
