[
https://issues.apache.org/jira/browse/BEAM-8348?focusedWorklogId=323766&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323766
]
ASF GitHub Bot logged work on BEAM-8348:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Oct/19 22:23
Start Date: 04/Oct/19 22:23
Worklog Time Spent: 10m
Work Description: ibzib commented on issue #9724: [BEAM-8348] make
job_name a standard option in Python SDK
URL: https://github.com/apache/beam/pull/9724#issuecomment-538578936
As expected, numerous test failures caused by `AttributeError:
'GoogleCloudOptions' object has no attribute 'job_name'`. Unfortunately, there
is no way to define attribute `job_name` in multiple `PipelineOptions`
subclasses given how options are structured. So the options I can see are a)
make the breaking change and update every location it occurs in Beam, or b) use
`GoogleCloudOptions` in non-Cloud related settings. Not particularly fond of
either one of them, but a) is probably the way it should have been originally.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 323766)
Time Spent: 40m (was: 0.5h)
> Portable Python job name hard-coded to "job"
> --------------------------------------------
>
> Key: BEAM-8348
> URL: https://issues.apache.org/jira/browse/BEAM-8348
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> See [1]. `job_name` is already taken by Google Cloud options [2], so I guess
> we should create a new option (maybe `portable_job_name` to avoid disruption).
> [[1]
> https://github.com/apache/beam/blob/55588e91ed8e3e25bb661a6202c31e99297e0e79/sdks/python/apache_beam/runners/portability/portable_runner.py#L294|https://github.com/apache/beam/blob/55588e91ed8e3e25bb661a6202c31e99297e0e79/sdks/python/apache_beam/runners/portability/portable_runner.py#L294]
> [2]
> [https://github.com/apache/beam/blob/c5bbb51014f7506a2651d6070f27fb3c3dc0da8f/sdks/python/apache_beam/options/pipeline_options.py#L438]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
