[
https://issues.apache.org/jira/browse/BEAM-8146?focusedWorklogId=327397&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327397
]
ASF GitHub Bot logged work on BEAM-8146:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Oct/19 23:14
Start Date: 12/Oct/19 23:14
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on issue #9493:
[BEAM-8146,BEAM-8204,BEAM-8205] Add equals and hashCode to SchemaCoder and
RowCoder
URL: https://github.com/apache/beam/pull/9493#issuecomment-541368760
Thanks @kennknowles, I resolved the merge conflicts so I think this is
ready.
It may be good to get a review from @reuvenlax before merging though, at
least an approval of the high-level approach. Plumbing through the type
descriptor and changing the `GetterBasedSchemaProvider` interface is a pretty
substantial change. The latter one will also cause a small conflict with #8690.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 327397)
Time Spent: 2.5h (was: 2h 20m)
> SchemaCoder/RowCoder have no equals() function
> ----------------------------------------------
>
> Key: BEAM-8146
> URL: https://issues.apache.org/jira/browse/BEAM-8146
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.15.0
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> SchemaCoder has no equals function, so it can't be compared in tests, like
> CloudComponentsTests$DefaultCoders, which is being re-enabled in
> https://github.com/apache/beam/pull/9446
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
