[
https://issues.apache.org/jira/browse/BEAM-8146?focusedWorklogId=330819&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330819
]
ASF GitHub Bot logged work on BEAM-8146:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Oct/19 23:36
Start Date: 18/Oct/19 23:36
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on issue #9493:
[BEAM-8146,BEAM-8204,BEAM-8205] Add equals and hashCode to SchemaCoder and
RowCoder
URL: https://github.com/apache/beam/pull/9493#issuecomment-544007362
That's a good point, I don't think so. Initially I added the type descriptor
as something we can verify as a proxy for `toRow`/`fromRow` but now that I've
made the functions created by our `SchemaProvider` implementations comparable,
that check is redundant. Do you think I should back out the type descriptor
changes to make this simpler? It's mostly its own commit so it wouldn't be too
hard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 330819)
Time Spent: 2h 50m (was: 2h 40m)
> SchemaCoder/RowCoder have no equals() function
> ----------------------------------------------
>
> Key: BEAM-8146
> URL: https://issues.apache.org/jira/browse/BEAM-8146
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.15.0
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> SchemaCoder has no equals function, so it can't be compared in tests, like
> CloudComponentsTests$DefaultCoders, which is being re-enabled in
> https://github.com/apache/beam/pull/9446
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
