[
https://issues.apache.org/jira/browse/BEAM-7886?focusedWorklogId=330292&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330292
]
ASF GitHub Bot logged work on BEAM-7886:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Oct/19 05:08
Start Date: 18/Oct/19 05:08
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #9188: [BEAM-7886]
Make row coder a standard coder and implement in Python
URL: https://github.com/apache/beam/pull/9188#discussion_r336321995
##########
File path: sdks/python/apache_beam/coders/standard_coders_test.py
##########
@@ -133,11 +171,17 @@ def parse_coder(self, spec):
for c in spec.get('components', ())]
context.coders.put_proto(coder_id, beam_runner_api_pb2.Coder(
spec=beam_runner_api_pb2.FunctionSpec(
- urn=spec['urn'], payload=spec.get('payload')),
+ urn=spec['urn'], payload=spec.get('payload', '').encode()),
Review comment:
Yep. Latin1 is the identity on the bottom 255 code bytes of unicode (and
rejects the rest).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 330292)
Time Spent: 13h 20m (was: 13h 10m)
> Make row coder a standard coder and implement in python
> -------------------------------------------------------
>
> Key: BEAM-7886
> URL: https://issues.apache.org/jira/browse/BEAM-7886
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-java-core, sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Time Spent: 13h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
