[
https://issues.apache.org/jira/browse/BEAM-7886?focusedWorklogId=330287&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330287
]
ASF GitHub Bot logged work on BEAM-7886:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Oct/19 05:04
Start Date: 18/Oct/19 05:04
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #9188: [BEAM-7886]
Make row coder a standard coder and implement in Python
URL: https://github.com/apache/beam/pull/9188#discussion_r336321453
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/CoderTranslators.java
##########
@@ -118,6 +124,33 @@ public T fromComponents(List<Coder<?>> components) {
};
}
+ static CoderTranslator<RowCoder> row() {
+ return new CoderTranslator<RowCoder>() {
+ @Override
+ public List<? extends Coder<?>> getComponents(RowCoder from) {
+ return ImmutableList.of();
Review comment:
For coders, if one had a coder T one was likely to have KV<K, T> for various
K, an Iterable<T>, WindowedValue<T> for possibly several window types, and
various other permutations. Coupled with the fact that leaf coders were often
huge serialized blobs made for some pretty significant savings.
Maybe this'll be less of an issue in the streaming world. I think it should
not be a blocker assuming we'll be able to update this in the (short-term)
future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 330287)
Time Spent: 13h (was: 12h 50m)
> Make row coder a standard coder and implement in python
> -------------------------------------------------------
>
> Key: BEAM-7886
> URL: https://issues.apache.org/jira/browse/BEAM-7886
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-java-core, sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Time Spent: 13h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
