[
https://issues.apache.org/jira/browse/BEAM-7013?focusedWorklogId=330566&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330566
]
ASF GitHub Bot logged work on BEAM-7013:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Oct/19 15:20
Start Date: 18/Oct/19 15:20
Worklog Time Spent: 10m
Work Description: zfraa commented on pull request #9778: [BEAM-7013]
Update BigQueryHllSketchCompatibilityIT to cover empty sketch cases
URL: https://github.com/apache/beam/pull/9778#discussion_r336524398
##########
File path:
sdks/java/extensions/zetasketch/src/test/java/org/apache/beam/sdk/extensions/zetasketch/BigQueryHllSketchCompatibilityIT.java
##########
@@ -126,22 +145,49 @@ public static void deleteDataset() throws Exception {
}
/**
- * Test that HLL++ sketch computed in BigQuery can be processed by Beam. Hll
sketch is computed by
- * {@code HLL_COUNT.INIT} in BigQuery and read into Beam; the test verifies
that we can run {@link
- * HllCount.MergePartial} and {@link HllCount.Extract} on the sketch in Beam
to get the correct
- * estimated count.
+ * Test that non-empty HLL++ sketch computed in BigQuery can be processed by
Beam.
+ *
+ * <p>Hll sketch is computed by {@code HLL_COUNT.INIT} in BigQuery and read
into Beam; the test
Review comment:
Nit: "Test that a HLL++ sketch...", and "The HLL sketch is computed...".
Otherwise, LGTM!
Also, all Javadoc should be in third person ("Tests that..." instead of
"Test that"; see
https://www.oracle.com/technetwork/articles/java/index-137868.html, "Use 3rd
person..."). Sorry that I missed this in the first version of this code!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 330566)
Time Spent: 35.5h (was: 35h 20m)
> A new count distinct transform based on BigQuery compatible HyperLogLog++
> implementation
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-7013
> URL: https://issues.apache.org/jira/browse/BEAM-7013
> Project: Beam
> Issue Type: New Feature
> Components: extensions-java-sketching, sdk-java-core
> Reporter: Yueyang Qiu
> Assignee: Yueyang Qiu
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 35.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
