[
https://issues.apache.org/jira/browse/BEAM-8456?focusedWorklogId=332965&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-332965
]
ASF GitHub Bot logged work on BEAM-8456:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/19 23:21
Start Date: 23/Oct/19 23:21
Worklog Time Spent: 10m
Work Description: apilloud commented on pull request #9849: [BEAM-8456]
Add pipeline option to have Data Catalog truncate sub-millisecond precision
URL: https://github.com/apache/beam/pull/9849#discussion_r338318184
##########
File path:
sdks/java/extensions/sql/datacatalog/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/datacatalog/DataCatalogTableProvider.java
##########
@@ -138,8 +143,41 @@ private Table loadTableFromDC(String tableName) {
}
}
- @Override
- public BeamSqlTable buildBeamSqlTable(Table table) {
- return delegateProviders.get(table.getType()).buildBeamSqlTable(table);
+ private static DataCatalogBlockingStub createDataCatalogClient(
+ DataCatalogPipelineOptions options) {
+ return DataCatalogGrpc.newBlockingStub(
+
ManagedChannelBuilder.forTarget(options.getDataCatalogEndpoint()).build())
+ .withCallCredentials(
+
MoreCallCredentials.from(options.as(GcpOptions.class).getGcpCredential()));
+ }
+
+ private static Map<String, TableProvider> getSupportedProviders() {
+ return Stream.of(
+ new PubsubJsonTableProvider(), new BigQueryTableProvider(), new
TextTableProvider())
+ .collect(toMap(TableProvider::getTableType, p -> p));
+ }
+
+ private Table toCalciteTable(String tableName, Entry entry) {
+ if (entry.getSchema().getColumnsCount() == 0) {
+ throw new UnsupportedOperationException(
+ "Entry doesn't have a schema. Please attach a schema to '"
+ + tableName
+ + "' in Data Catalog: "
+ + entry.toString());
+ }
+ Schema schema = SchemaUtils.fromDataCatalog(entry.getSchema());
+
+ Optional<Table.Builder> tableBuilder = tableFactory.tableBuilder(entry);
+ if (tableBuilder.isPresent()) {
+ return tableBuilder.get().schema(schema).name(tableName).build();
+ } else {
Review comment:
nit: unneeded `else`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 332965)
Time Spent: 1h 50m (was: 1h 40m)
> BigQuery to Beam SQL timestamp has the wrong default: truncation makes the
> most sense
> -------------------------------------------------------------------------------------
>
> Key: BEAM-8456
> URL: https://issues.apache.org/jira/browse/BEAM-8456
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Most of the time, a user reading a timestamp from BigQuery with
> higher-than-millisecond precision timestamps may not even realize that the
> data source created these high precision timestamps. They are probably
> timestamps on log entries generated by a system with higher precision.
> If they are using it with Beam SQL, which only supports millisecond
> precision, it makes sense to "just work" by default.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
