[
https://issues.apache.org/jira/browse/BEAM-8456?focusedWorklogId=332963&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-332963
]
ASF GitHub Bot logged work on BEAM-8456:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/19 23:21
Start Date: 23/Oct/19 23:21
Worklog Time Spent: 10m
Work Description: apilloud commented on pull request #9849: [BEAM-8456]
Add pipeline option to have Data Catalog truncate sub-millisecond precision
URL: https://github.com/apache/beam/pull/9849#discussion_r338317396
##########
File path:
sdks/java/extensions/sql/datacatalog/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/datacatalog/TableFactory.java
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.sql.meta.provider.datacatalog;
+
+import com.google.cloud.datacatalog.Entry;
+import java.util.Optional;
+import org.apache.beam.sdk.extensions.sql.meta.Table.Builder;
+
+interface TableFactory {
+ Optional<Builder> tableBuilder(Entry entry);
Review comment:
It is probably worth documenting this interface. Particularly that the
`TableFactory` should check to see if the `Entry` belongs to it and return
`Optional.empty()` if it doesn't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 332963)
Time Spent: 1h 40m (was: 1.5h)
> BigQuery to Beam SQL timestamp has the wrong default: truncation makes the
> most sense
> -------------------------------------------------------------------------------------
>
> Key: BEAM-8456
> URL: https://issues.apache.org/jira/browse/BEAM-8456
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Most of the time, a user reading a timestamp from BigQuery with
> higher-than-millisecond precision timestamps may not even realize that the
> data source created these high precision timestamps. They are probably
> timestamps on log entries generated by a system with higher precision.
> If they are using it with Beam SQL, which only supports millisecond
> precision, it makes sense to "just work" by default.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
