[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=334659&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-334659
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Oct/19 20:47
Start Date: 27/Oct/19 20:47
Worklog Time Spent: 10m
Work Description: chadrik commented on issue #9056: [BEAM-7746] Add
python type hints
URL: https://github.com/apache/beam/pull/9056#issuecomment-546732744
Alright everyone, I'm happy with where this PR is now, and I think it's time
to start figuring out how to get it merged.
This PR is admittedly huge, but the daunting scope is mitigated by the fact
that the intent of the PR is to _avoid making any behavioral changes_. I
recommend reviewing this PR one commit at a time, as I've tried to organize it
into bite-sized chunks, and I've segregated changes with possible unintentional
runtime side-effects and made note of them for extra scrutiny.
An additional consideration with respect to the size of this PR is that
there is a critical mass required before mypy can be enabled in CI, so if we
were to break up this PR, we wouldn't be able to enable the mypy lint until all
of the changes are finally merged (the alternative is hundreds `# type: ignore`
comments throughout the code, which I'd rather not do). Once this PR goes in,
it'll be easy to make smaller follow-ups.
I'm really excited about this PR and I think you all are going to find the
code base much easier to navigate and grok once it's in (I already provide this
branch to others on the team who are trying to learn beam), not to mention the
deep structural analysis that you get during testing (it's helped me to
identify a number of real and potential bugs already, which you'll see in my
commits).
One final consideration: there _will_ be a need for training and mentoring
on static type analysis, I have some internal docs on the subject which I'm
happy to share, and you can always drag me into a PR to help resolve issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 334659)
Time Spent: 11h (was: 10h 50m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 11h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
