[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=335122&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-335122
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Oct/19 19:07
Start Date: 28/Oct/19 19:07
Worklog Time Spent: 10m
Work Description: robertwb commented on issue #9056: [BEAM-7746] Add
python type hints
URL: https://github.com/apache/beam/pull/9056#issuecomment-547100645
Thanks for the huge amount of work that's gone into this PR, and I'm looking
forwards to the benefits it'll bring to the codebase.
In terms of getting this reviewed, I understand that mypy can't be enabled
[1] until it's all in, but I think it's preferable to get individual commits
merged and in incrementally than review commits incrementally and then try to
get them all in at once in a single PR. In my spot checking it seems these
commits are relatively orthogonal--is that basically the case? Perhaps a
reviewer could create PRs cherry-picking commits that they are able to review
in one sitting and we could get them in that way? Any other ideas?
[1] Maybe we could enable it, but not make it a blocker, in which case we
could track progress and at least manually track progress/slippage until we
enforce it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 335122)
Time Spent: 11h 20m (was: 11h 10m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
