[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=336403&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-336403
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Oct/19 19:01
Start Date: 30/Oct/19 19:01
Worklog Time Spent: 10m
Work Description: udim commented on pull request #9056: [BEAM-7746] Add
python type hints
URL: https://github.com/apache/beam/pull/9056#discussion_r340782178
##########
File path: sdks/python/build-requirements.txt
##########
@@ -0,0 +1,20 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+# TODO(BEAM-5414): latest grpcio-tools incompatible with latest protobuf 3.6.1.
+grpcio-tools>=1.3.5,<=1.14.2
+mypy-protobuf==1.12
+future==0.16.0
Review comment:
This addition of this file needs a discussion.
- This file needs a description. Which dependencies should be included here?
- Additionally, which dependencies should by setup.py, the gradle
setupVirtualenv task, gen_protos.py, etc?
- Ideally dependencies should only be listed once, so I am for this kind of
change.
- Why is `future` listed here? It's already in `setup.py`. I saw that some
tox envs needed it, but it seems that if tox installs the apache-beam tarball
in the virtualenv it creates then that should include future as well.
- Why is `mypy-protobuf` here? Only the `mypy` command from setup.py seems
to need it, so it could be listed under `REQUIRED_TEST_PACKAGES` there.
- I do agree that the grpcio-tools dep should be listed in one place so
maybe this file could serve that purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 336403)
Time Spent: 13.5h (was: 13h 20m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 13.5h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
