[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=336404&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-336404
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Oct/19 19:01
Start Date: 30/Oct/19 19:01
Worklog Time Spent: 10m
Work Description: udim commented on pull request #9056: [BEAM-7746] Add
python type hints
URL: https://github.com/apache/beam/pull/9056#discussion_r340765902
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1768,7 +1768,7 @@ class BeamModulePlugin implements Plugin<Project> {
project.exec { commandLine virtualenvCmd }
project.exec {
executable 'sh'
- args '-c', ". ${project.ext.envdir}/bin/activate && pip install
--retries 10 --upgrade tox==3.11.1 grpcio-tools==1.3.5"
+ args '-c', ". ${project.ext.envdir}/bin/activate && pip install
--retries 10 --upgrade tox==3.11.1 -r
${project.rootDir}/sdks/python/build-requirements.txt"
Review comment:
I'd rather limit the packages installed in the base virtualenv.
`setup.py` should contain the list of packages needed (under
`REQUIRED_TEST_PACKAGES` in this case). Note that it already lists `future` as
a dependency.
IIUC mypy is run via `setup.py` so listing the dependencies there makes
sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 336404)
Time Spent: 13.5h (was: 13h 20m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 13.5h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
