[
https://issues.apache.org/jira/browse/BEAM-8523?focusedWorklogId=337519&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337519
]
ASF GitHub Bot logged work on BEAM-8523:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Nov/19 19:39
Start Date: 01/Nov/19 19:39
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #9959: WIP:
[BEAM-8523] JobAPI: Give access to timestamped state change history
URL: https://github.com/apache/beam/pull/9959#discussion_r341722020
##########
File path: model/job-management/src/main/proto/beam_job_api.proto
##########
@@ -153,6 +154,7 @@ message GetJobStateRequest {
message GetJobStateResponse {
Review comment:
ok, saw your comment from Jira:
> Typically when you would connect you would want to give some lower bound
to filter messages. For example GetJobStateRequest could become:
>
> ```proto
> message GetJobStateRequest {
> string job_id = 1; // (required)
> // (Optional) If specified, only state transitions after
> // the provided timestamp will be provided.
> google.protobuf.Timestamp min_message_timestamp;
> }
> ```
I agree with this conceptually, but was hoping to defer the addition of this
until I get to the message stream. The state stream is typically going to be
just a few events, so practically speaking, the additional of
`min_message_timestamp` here will not be very impactful. The size of the
backfill for the message stream on the other hand, with the changes that I'd
like to add to it, could be significant, and there could be a number of ways
that a user may want to filter (`min_message_timestamp`, `max_num_messages`,
`importance`, etc). I'd like the APIs to be similar between the two, and I
think the work donw on GetMessageStream will inform our choices for
GetStateStream.
tl;dr I'd like to defer the addition of this until later, if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 337519)
Time Spent: 1h 20m (was: 1h 10m)
> Add useful timestamp to job servicer GetJobs
> --------------------------------------------
>
> Key: BEAM-8523
> URL: https://issues.apache.org/jira/browse/BEAM-8523
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> As a user querying jobs with JobService.GetJobs, it would be useful if the
> JobInfo result contained timestamps indicating various state changes that may
> have been missed by a client. Useful timestamps include:
>
> * submitted (prepared to the job service)
> * started (executor enters the RUNNING state)
> * completed (executor enters a terminal state)
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
