[
https://issues.apache.org/jira/browse/BEAM-8575?focusedWorklogId=339672&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339672
]
ASF GitHub Bot logged work on BEAM-8575:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/19 01:22
Start Date: 07/Nov/19 01:22
Worklog Time Spent: 10m
Work Description: liumomo315 commented on issue #9957: [BEAM-8575] Add
validates runner tests for 1. Custom window fn: Test a customized window fn
work as expected; 2. Windows idempotency: Applying the same window fn (or
window fn + GBK) to the input multiple times will have the same effect as
applying it once.
URL: https://github.com/apache/beam/pull/9957#issuecomment-550576421
> Welcome to Beam, all non-trivial PRs are meant to be accompanied with a
JIRA in the title as per the [contribution
guide](https://beam.apache.org/contribute/#share-your-intent).
>
Thanks for the pointer. Added JIRA:)
> Also, please address the lint issue:
>
> ```
> Task :sdks:python:test-suites:tox:py37:lintPy37
> 15:45:38 ************* Module apache_beam.transforms.window_test
> 15:45:38 apache_beam/transforms/window_test.py:283:48: E0110: Abstract
class 'TestCustomWindows' with abstract methods instantiated
(abstract-class-instantiated)
> ```
Done fully implementing it, but have a question on whether I could make it
simpler without changing other files, in another thread. Also cc'ed you there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 339672)
Time Spent: 40m (was: 0.5h)
> Add more Python validates runner tests
> --------------------------------------
>
> Key: BEAM-8575
> URL: https://issues.apache.org/jira/browse/BEAM-8575
> Project: Beam
> Issue Type: Test
> Components: sdk-py-core, testing
> Reporter: wendy liu
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This is the umbrella issue to track the work of adding more Python tests to
> improve test coverage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
