[
https://issues.apache.org/jira/browse/BEAM-8575?focusedWorklogId=340758&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340758
]
ASF GitHub Bot logged work on BEAM-8575:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/19 21:40
Start Date: 08/Nov/19 21:40
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9957: [BEAM-8575]
Add validates runner tests for 1. Custom window fn: Test a customized window fn
work as expected; 2. Windows idempotency: Applying the same window fn (or
window fn + GBK) to the input multiple times will have the same effect as
applying it once.
URL: https://github.com/apache/beam/pull/9957#discussion_r344375411
##########
File path: sdks/python/apache_beam/portability/common_urns.py
##########
@@ -80,6 +80,10 @@ def PropertiesFromPayloadType(payload_type):
session_windows = PropertiesFromPayloadType(
standard_window_fns_pb2.SessionsPayload)
+# Custom window for test only.
+test_custom_windows = PropertiesFromPayloadType(
Review comment:
should not be defined here but locally within the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 340758)
Time Spent: 1h 40m (was: 1.5h)
> Add more Python validates runner tests
> --------------------------------------
>
> Key: BEAM-8575
> URL: https://issues.apache.org/jira/browse/BEAM-8575
> Project: Beam
> Issue Type: Test
> Components: sdk-py-core, testing
> Reporter: wendy liu
> Assignee: wendy liu
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> This is the umbrella issue to track the work of adding more Python tests to
> improve test coverage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
