[
https://issues.apache.org/jira/browse/BEAM-8554?focusedWorklogId=340701&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340701
]
ASF GitHub Bot logged work on BEAM-8554:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/19 19:27
Start Date: 08/Nov/19 19:27
Worklog Time Spent: 10m
Work Description: scwhittle commented on pull request #10013: [BEAM-8554]
Use WorkItemCommitRequest protobuf fields to signal that …
URL: https://github.com/apache/beam/pull/10013#discussion_r344331362
##########
File path:
runners/google-cloud-dataflow-java/worker/windmill/src/main/proto/windmill.proto
##########
@@ -293,19 +293,16 @@ message WorkItemCommitRequest {
optional SourceState source_state_updates = 12;
optional int64 source_watermark = 13 [default=-0x8000000000000000];
optional int64 source_backlog_bytes = 17 [default=-1];
- optional int64 source_bytes_processed = 22 [default = 0];
+ optional int64 source_bytes_processed = 22;
repeated WatermarkHold watermark_holds = 14;
- repeated int64 finalize_ids = 19 [packed = true];
-
- optional int64 testonly_fake_clock_time_usec = 23;
-
// DEPRECATED
repeated GlobalDataId global_data_id_requests = 9;
reserved 6;
Review comment:
Nit but I think you can do
reserved 6, 19, 23;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 340701)
Time Spent: 1h 50m (was: 1h 40m)
> Use WorkItemCommitRequest protobuf fields to signal that a WorkItem needs to
> be broken up
> -----------------------------------------------------------------------------------------
>
> Key: BEAM-8554
> URL: https://issues.apache.org/jira/browse/BEAM-8554
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Steve Koonce
> Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> +Background:+
> When a WorkItemCommitRequest is generated that's bigger than the permitted
> size (> ~180 MB), a KeyCommitTooLargeException is logged (_not thrown_) and
> the request is still sent to the service. The service rejects the commit,
> but breaks up input messages that were bundled together and adds them to new,
> smaller work items that will later be pulled and re-tried - likely without
> generating another commit that is too large.
> When a WorkItemCommitRequest is generated that's too large to be sent back to
> the service (> 2 GB), a KeyCommitTooLargeException is thrown and nothing is
> sent back to the service.
>
> +Proposed Improvement+
> In both cases, prevent the doomed, large commit item from being sent back to
> the service. Instead send flags in the commit request signaling that the
> current work item led to a commit that is too large and the work item should
> be broken up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
