[
https://issues.apache.org/jira/browse/BEAM-8554?focusedWorklogId=342959&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-342959
]
ASF GitHub Bot logged work on BEAM-8554:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/19 22:11
Start Date: 13/Nov/19 22:11
Worklog Time Spent: 10m
Work Description: scwhittle commented on issue #10013: [BEAM-8554] Use
WorkItemCommitRequest protobuf fields to signal that …
URL: https://github.com/apache/beam/pull/10013#issuecomment-553627998
We want to only set the necessary routing information (ie key, work_token,
cache_token etc) but not keep all the other data, which is using many bytes.
On Wed, Nov 13, 2019 at 2:09 PM reuvenlax <notificati...@github.com> wrote:
> *@reuvenlax* commented on this pull request.
> ------------------------------
>
> In
>
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
> <https://github.com/apache/beam/pull/10013#discussion_r346028789>:
>
> > KeyCommitTooLargeException e =
> KeyCommitTooLargeException.causedBy(computationId, byteLimit,
commitRequest);
> reportFailure(computationId, workItem, e);
> LOG.error(e.toString());
> +
> + commitRequest = buildWorkItemTruncationRequest(key, workItem,
estimatedCommitSize);
>
> Instead of reinitializing everything from scratch, can't you just reuse
> the existing commitRequest? Something like:
>
> commitRequest = commitRequest.toBuilder().
>
setExceedsMaxWorkItemCommitBytes(true).setEstimatedWorkItemCommitBytes(estimatedCommitSize).build()
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/beam/pull/10013?email_source=notifications&email_token=ABBZZTBIOBV54TWSMJSWHMDQTR3JPA5CNFSM4JJ4E4ZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLPMZ2A#pullrequestreview-316591336>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/ABBZZTDX62W3FDHUADQB77DQTR3JPANCNFSM4JJ4E4ZA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 342959)
Time Spent: 3h 10m (was: 3h)
> Use WorkItemCommitRequest protobuf fields to signal that a WorkItem needs to
> be broken up
> -----------------------------------------------------------------------------------------
>
> Key: BEAM-8554
> URL: https://issues.apache.org/jira/browse/BEAM-8554
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Steve Koonce
> Priority: Minor
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> +Background:+
> When a WorkItemCommitRequest is generated that's bigger than the permitted
> size (> ~180 MB), a KeyCommitTooLargeException is logged (_not thrown_) and
> the request is still sent to the service. The service rejects the commit,
> but breaks up input messages that were bundled together and adds them to new,
> smaller work items that will later be pulled and re-tried - likely without
> generating another commit that is too large.
> When a WorkItemCommitRequest is generated that's too large to be sent back to
> the service (> 2 GB), a KeyCommitTooLargeException is thrown and nothing is
> sent back to the service.
>
> +Proposed Improvement+
> In both cases, prevent the doomed, large commit item from being sent back to
> the service. Instead send flags in the commit request signaling that the
> current work item led to a commit that is too large and the work item should
> be broken up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
