ASF GitHub Bot logged work on BEAM-8157:

                Author: ASF GitHub Bot
            Created on: 09/Nov/19 18:22
            Start Date: 09/Nov/19 18:22
    Worklog Time Spent: 10m 
      Work Description: mxm commented on pull request #9997: [BEAM-8157] Fix 
key encoding issues for state requests with unknown coders / Improve debugging 
and testing
URL: https://github.com/apache/beam/pull/9997#discussion_r344455906

 File path: 
 @@ -98,6 +100,8 @@ PortablePipelineResult runPipelineWithTranslator(
             ? trimmedPipeline
             : GreedyPipelineFuser.fuse(trimmedPipeline).toPipeline();
+    fusedPipeline = lengthPrefixKeyCoderOfStatefulStages(fusedPipeline);
 Review comment:
   Just saw your comment when I updated the PR. I've moved the logic for key 
length prefixing to `GreedyStageFuser`. Good idea to move the other functions 
into a utility class, but I believe this is out of scope for this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 340940)
    Time Spent: 9h 40m  (was: 9.5h)

> Key encoding for state requests is not consistent across SDKs
> -------------------------------------------------------------
>                 Key: BEAM-8157
>                 URL: https://issues.apache.org/jira/browse/BEAM-8157
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>    Affects Versions: 2.13.0
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Critical
>             Fix For: 2.17.0
>          Time Spent: 9h 40m
>  Remaining Estimate: 0h
> The Flink runner requires the internal key to be encoded without a length 
> prefix (OUTER context). The user state request handler exposes a serialized 
> version of the key to the Runner. This key is encoded with the NESTED context 
> which may add a length prefix. We need to convert it to OUTER context to 
> match the Flink runner's key encoding.
> So far this has not caused the Flink Runner to behave incorrectly. However, 
> with the upcoming support for Flink 1.9, the state backend will not accept 
> requests for keys not part of any key group/partition of the operator. This 
> is very likely to happen with the encoding not being consistent.
> **NOTE** This is only applicable to the Java SDK, as the Python SDK uses 
> OUTER encoding for the key in state requests.

This message was sent by Atlassian Jira

Reply via email to