[
https://issues.apache.org/jira/browse/BEAM-8157?focusedWorklogId=341493&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341493
]
ASF GitHub Bot logged work on BEAM-8157:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/19 21:40
Start Date: 11/Nov/19 21:40
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9997: [BEAM-8157]
Fix key encoding issues for state requests with unknown coders / Improve
debugging and testing
URL: https://github.com/apache/beam/pull/9997#discussion_r344921260
##########
File path: sdks/python/apache_beam/runners/portability/flink_runner_test.py
##########
@@ -155,6 +155,38 @@ def create_options(self):
options.view_as(StandardOptions).streaming = True
return options
+ def test_pardo_state_with_custom_key_coder(self):
Review comment:
should we add this the `portable_runner_test.py` and ensure that all runners
are executing it (and possibly skipping it if they don't support it).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 341493)
Time Spent: 11h 20m (was: 11h 10m)
> Key encoding for state requests is not consistent across SDKs
> -------------------------------------------------------------
>
> Key: BEAM-8157
> URL: https://issues.apache.org/jira/browse/BEAM-8157
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Affects Versions: 2.13.0
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Critical
> Fix For: 2.17.0
>
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> The Flink runner requires the internal key to be encoded without a length
> prefix (OUTER context). The user state request handler exposes a serialized
> version of the key to the Runner. This key is encoded with the NESTED context
> which may add a length prefix. We need to convert it to OUTER context to
> match the Flink runner's key encoding.
> So far this has not caused the Flink Runner to behave incorrectly. However,
> with the upcoming support for Flink 1.9, the state backend will not accept
> requests for keys not part of any key group/partition of the operator. This
> is very likely to happen with the encoding not being consistent.
> **NOTE** This is only applicable to the Java SDK, as the Python SDK uses
> OUTER encoding for the key in state requests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
