[
https://issues.apache.org/jira/browse/BEAM-8581?focusedWorklogId=341577&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341577
]
ASF GitHub Bot logged work on BEAM-8581:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/19 00:49
Start Date: 12/Nov/19 00:49
Worklog Time Spent: 10m
Work Description: dpmills commented on pull request #10035: [BEAM-8581]
and [BEAM-8582] watermark and trigger fixes
URL: https://github.com/apache/beam/pull/10035#discussion_r344973332
##########
File path: sdks/python/apache_beam/testing/util.py
##########
@@ -87,27 +88,56 @@ def __repr__(self):
def equal_to_per_window(expected_window_to_elements):
- """Matcher used by assert_that to check on values for specific windows.
+ """Matcher used by assert_that to check to assert expected windows..
+
+ The 'assert_that' statement must have reify_windows=True. This assertion
works
Review comment:
Given that the matcher has to know if it expects windows to be reified, can
we make that happen automatically and remove this setting?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 341577)
Time Spent: 40m (was: 0.5h)
> Python SDK labels ontime empty panes as late
> --------------------------------------------
>
> Key: BEAM-8581
> URL: https://issues.apache.org/jira/browse/BEAM-8581
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The GeneralTriggerDriver does not put watermark holds on timers, leading to
> the ontime empty pane being considered late data.
> Fix: Add a new notion of whether a trigger has an ontime pane. If it does,
> then set a watermark hold to end of window - 1.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
