[
https://issues.apache.org/jira/browse/BEAM-8581?focusedWorklogId=342188&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-342188
]
ASF GitHub Bot logged work on BEAM-8581:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/19 21:38
Start Date: 12/Nov/19 21:38
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10035: [BEAM-8581]
and [BEAM-8582] watermark and trigger fixes
URL: https://github.com/apache/beam/pull/10035#discussion_r345453855
##########
File path: sdks/python/apache_beam/transforms/trigger.py
##########
@@ -277,6 +288,10 @@ def on_merge(self, to_be_merged, merge_result, context):
context.clear_timer('', TimeDomain.WATERMARK)
def should_fire(self, time_domain, watermark, window, context):
+ # Explicitly clear the timer so that late elements are not emitted again
Review comment:
This comment only applies to the if clause; move there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 342188)
Time Spent: 1.5h (was: 1h 20m)
> Python SDK labels ontime empty panes as late
> --------------------------------------------
>
> Key: BEAM-8581
> URL: https://issues.apache.org/jira/browse/BEAM-8581
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The GeneralTriggerDriver does not put watermark holds on timers, leading to
> the ontime empty pane being considered late data.
> Fix: Add a new notion of whether a trigger has an ontime pane. If it does,
> then set a watermark hold to end of window - 1.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
