[
https://issues.apache.org/jira/browse/BEAM-8338?focusedWorklogId=341834&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341834
]
ASF GitHub Bot logged work on BEAM-8338:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/19 11:20
Start Date: 12/Nov/19 11:20
Worklog Time Spent: 10m
Work Description: regfaker commented on issue #10025: [BEAM-8338] Support
ES 7.x for ElasticsearchIO
URL: https://github.com/apache/beam/pull/10025#issuecomment-551982080
@echauchot At rest level (I mean requests) there are no breaking changes. I
found couple of them at RestClient level itself when I upgraded es client
dependency and that is what I'm working on now (almost finished).
But at all I don't like this concept of ifing several versions in one class.
Wouldn't it be better to have multiple ElasticsearchIO clients (per version)
and ElasticsearchIO will use the one it needs (this will need some shading or
if there is some other possibility in gradle (I'm not familiar with it))? I
think that it is not sustainable in this state (for example if some big
breaking change in RestClient will come and some of older versions (v2) will
stop work).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 341834)
Time Spent: 3h (was: 2h 50m)
> Support ES 7.x for ElasticsearchIO
> ----------------------------------
>
> Key: BEAM-8338
> URL: https://issues.apache.org/jira/browse/BEAM-8338
> Project: Beam
> Issue Type: Improvement
> Components: io-java-elasticsearch
> Reporter: Michal Brunát
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Elasticsearch has released 7.4 but ElasticsearchIO only supports 2x,5.x,6.x.
> We should support ES 7.x for ElasticsearchIO.
> [https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html]
>
> [https://github.com/apache/beam/blob/master/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
