[
https://issues.apache.org/jira/browse/BEAM-3419?focusedWorklogId=343024&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-343024
]
ASF GitHub Bot logged work on BEAM-3419:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/19 00:16
Start Date: 14/Nov/19 00:16
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #10092: [BEAM-3419]
Explicitly model iterable side inputs as part of the Beam portability APIs.
URL: https://github.com/apache/beam/pull/10092#discussion_r346070611
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -318,7 +318,15 @@ message StandardPTransforms {
message StandardSideInputTypes {
enum Enum {
+ // Represents a view over a PCollection<V>.
+ //
+ // The SDK is limited to perform state get requests using the
StateKey.IterableSideInput.
ITERABLE = 0 [(beam_urn) = "beam:side_input:iterable:v1"];
+
+ // Represents a view over a PCollection<KV<K, V>>.
+ //
+ // The SDK is able to perform state get requests with the
StateKey.IterableSideInput and
Review comment:
In the same vein as the comments above, I think these lines would be less
ambiguous like so:
"StateGetRequests performed on this side input must use
StateKey.IterableSideInput or StateKey.MultimapSideInput."
Like my other comments, the important change is that StateGetRequests are
explicitly mentioned as _using_ the StateKey and being performed _on_ the side
input represented by this URN.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 343024)
Time Spent: 1h (was: 50m)
> Enable iterable side input for beam runners.
> --------------------------------------------
>
> Key: BEAM-3419
> URL: https://issues.apache.org/jira/browse/BEAM-3419
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Robert Bradshaw
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
