[
https://issues.apache.org/jira/browse/BEAM-3419?focusedWorklogId=343022&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-343022
]
ASF GitHub Bot logged work on BEAM-3419:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/19 00:16
Start Date: 14/Nov/19 00:16
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #10092: [BEAM-3419]
Explicitly model iterable side inputs as part of the Beam portability APIs.
URL: https://github.com/apache/beam/pull/10092#discussion_r346063054
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -637,6 +637,13 @@ message StateKey {
bytes key = 1;
}
+ // Represents a request for the values associated with a specified user key
and window
+ // in a PCollection.
+ //
+ // Can only perform StateGetRequests on side inputs with the URN
beam:side_input:multimap:v1.
Review comment:
As someone who doesn't already know how StateGetRequests/SideInputs work in
the FnAPI, I misinterpreted this comment at first until I looked into
StateGetRequests and side inputs more. To avoid that I'd suggest rewording it
like so:
"Can only **_be used to_** perform StateGetRequests on side inputs ~~with~~
_**of**_ the URN beam:side_input:multimap:v1."
The changes are small, but it makes the sentence less ambiguous when you
don't fully understand what's happening like I did when first reading this code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 343022)
Time Spent: 50m (was: 40m)
> Enable iterable side input for beam runners.
> --------------------------------------------
>
> Key: BEAM-3419
> URL: https://issues.apache.org/jira/browse/BEAM-3419
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Robert Bradshaw
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
